Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/scaffolder-backend-module-rails/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-backend": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from a workspace reference (workspace:^) to a pinned version (0.1.1) breaks the local package linking that's essential in a monorepo setup. This will likely cause compatibility issues with other local packages that expect to use the workspace version.

The PR description confirms that the yarn.lock update failed, which is a clear indicator of dependency resolution problems. Before merging:

  1. Run yarn to properly update all dependencies
  2. Verify the yarn.lock file is correctly updated
  3. Consider whether this security fix should be applied through a different approach that maintains workspace references

If the goal is to address the multer vulnerabilities, it might be better to update the dependency in the main package rather than changing the reference pattern.

Suggested change
"@backstage/plugin-scaffolder-backend": "0.1.1",
+ "@backstage/plugin-scaffolder-backend": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/types": "workspace:^",
"command-exists": "^1.2.9",
Expand Down
Loading