Skip to content

[Snyk] Fix for 18 vulnerabilities #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 18 vulnerabilities #5243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-openapi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
"@apidevtools/json-schema-ref-parser": "^9.0.6",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "2.0.0",
"@backstage/plugin-catalog-common": "0.1.0",
Comment on lines +38 to +41
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace:^ references with pinned versions (0.1.1, 2.0.0, 0.1.0) could introduce compatibility issues with other packages in the monorepo. These specific versions appear significantly older than what would be current in the workspace.

A more sustainable approach would be to address the vulnerabilities at their source within the workspace dependencies rather than pinning to older versions. This maintains the workspace reference pattern while still resolving the security concerns.

Consider:

  1. Updating the vulnerable dependencies in their source packages
  2. Using dependency overrides if specific packages need patching
  3. Maintaining the workspace:^ references to ensure consistent versioning across the monorepo

This approach would resolve the security issues while preserving the monorepo's dependency management strategy.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "2.0.0",
"@backstage/plugin-catalog-common": "0.1.0",
+ "@backstage/config": "workspace:^",
"@backstage/integration": "workspace:^",
+ "@backstage/plugin-catalog-backend": "workspace:^",
+ "@backstage/plugin-catalog-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/types": "workspace:^",
"winston": "^3.2.1",
Expand Down
Loading