Skip to content

[Snyk] Fix for 71 vulnerabilities #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 71 vulnerabilities #5265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plugins/scaffolder-backend-module-cookiecutter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.6.2",
"@backstage/types": "0.1.1",
Comment on lines +26 to +32
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references (workspace:^) with specific version numbers, which breaks the monorepo dependency structure. In a Backstage monorepo, internal packages should reference each other using the workspace protocol to ensure they use local versions rather than published npm versions.

Replacing workspace:^ with fixed versions will cause dependency resolution issues and potential version mismatches across the codebase. The original workspace references should be preserved to maintain proper monorepo functionality.

- "@backstage/backend-common": "0.24.1",
+ "@backstage/backend-common": "workspace:^",

While fixing vulnerabilities is important, it should be done without breaking the workspace dependency structure.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.6.2",
"@backstage/types": "0.1.1",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"command-exists": "^1.2.9",
"fs-extra": "10.1.0",
"winston": "^3.2.1",
Expand Down
Loading