Skip to content

[Snyk] Fix for 1 vulnerabilities#5266

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-b94fe8b7176cdd87456d397b266f9124
Closed

[Snyk] Fix for 1 vulnerabilities#5266
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-b94fe8b7176cdd87456d397b266f9124

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Jun 3, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/catalog-backend-module-gerrit/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Improper Link Resolution Before File Access ('Link Following')
SNYK-JS-TARFS-10293725
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improper Link Resolution Before File Access ('Link Following')

Summary by Sourcery

Fix a high-severity directory traversal vulnerability in tar-fs by upgrading key Backstage dependencies in the catalog-backend-module-gerrit package.

Bug Fixes:

  • Resolve SNYK-JS-TARFS-10293725 vulnerability by bumping dependencies to non-vulnerable versions.

Enhancements:

  • Upgrade @backstage/backend-common to 0.24.1.
  • Upgrade @backstage/catalog-model to 0.1.1.
  • Upgrade @backstage/plugin-catalog-node to 1.0.0.

…nerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-TARFS-10293725
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jun 3, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2025

Reviewer's Guide

This PR replaces workspace-scoped version references with explicit, patched version pins for key Backstage dependencies in the catalog-backend-module-gerrit plugin’s package.json to bump the transitive tarfs package and resolve the high-severity Link Following vulnerability (SNYK-JS-TARFS-10293725). Note that the yarn.lock must be updated manually before merging.

Sequence Diagram: Snyk Automated Dependency Update and Developer Actions

sequenceDiagram
    participant SnykService as "Snyk Service"
    participant GitHubRepo as "Project Repository"
    actor Developer

    SnykService->>GitHubRepo: Scans 'plugins/catalog-backend-module-gerrit' dependencies
    SnykService->>GitHubRepo: Creates PR with package.json updates (e.g., @backstage/backend-common, @backstage/catalog-model)
    Developer->>GitHubRepo: Receives PR notification for SNYK-JS-TARFS-10293725 fix
    Developer->>GitHubRepo: Reviews changes in 'plugins/catalog-backend-module-gerrit/package.json'
    Developer->>Developer: Manually runs `yarn` to update yarn.lock
    Developer->>GitHubRepo: Commits & pushes updated yarn.lock
    Developer->>GitHubRepo: Merges PR
Loading

File-Level Changes

Change Details Files
Pin Backstage dependencies to fixed versions to apply Snyk security fix
  • @backstage/backend-common: workspace:^ → 0.24.1
  • @backstage/catalog-model: workspace:^ → 0.1.1
  • @backstage/plugin-catalog-node: workspace:^ → 1.0.0
plugins/catalog-backend-module-gerrit/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented Jun 3, 2025

Snyk checks have failed. 1 issues have been found so far.

Icon Severity Issues
Critical 0
High 0
Medium 1
Low 0

security/snyk check is complete. 1 issues have been found. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version 0.1.1 specified for @backstage/catalog-model appears to be significantly outdated compared to the other Backstage packages being updated in this PR (such as backend-common to 0.24.1 and plugin-catalog-node to 1.0.0).

This version discrepancy will likely cause compatibility issues since these packages are designed to work together at similar version levels. Consider updating catalog-model to a version that aligns with the other packages being modified to ensure proper functionality and avoid dependency conflicts.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/catalog-model": "^1.0.0",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn High
spdx-exceptions@2.3.0 has a License Policy Violation.

License: CC-BY-3.0 (npm metadata)

License: CC-BY-3.0 (package/package.json)

From: yarn.locknpm/spdx-exceptions@2.3.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/spdx-exceptions@2.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 10, 2025
@github-actions github-actions Bot closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants