Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/errors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from workspace:^ to a fixed version 0.1.1 breaks the monorepo's workspace dependency resolution. In a monorepo, workspace:^ ensures that the local version of @backstage/types is used during development, maintaining consistency across packages.

Replacing it with a fixed version will:

  1. Pull @backstage/types from the npm registry instead of using the local version
  2. Potentially create version conflicts with other packages using the workspace version
  3. Complicate development workflows as changes to the local types package won't be reflected

While addressing the security vulnerability is important, consider an alternative approach that maintains the workspace structure, such as updating the vulnerable dependency within the types package itself.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"cross-fetch": "^3.1.5",
"serialize-error": "^8.0.1"
},
Expand Down
Loading