[Snyk] Fix for 3 vulnerabilities#5299
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TARFS-10293725 - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691387 - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThis PR patches three security vulnerabilities by upgrading the CLI package’s dependencies: pinning @backstage/config-loader to v0.1.1 and bumping webpack-dev-server to v5.2.2. Updated Class Diagram for packages/cli/package.jsonclassDiagram
class CliPackageConfig {
<<package.json>>
path: "packages/cli/package.json"
dependency_change_config_loader: "@backstage/config-loader: workspace:^ -> 0.1.1"
devDependency_change_webpack_server: "webpack-dev-server: ^4.7.3 -> ^5.2.2"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@backstage/cli-node": "workspace:^", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/config-loader": "workspace:^", | ||
| "@backstage/config-loader": "0.1.1", |
There was a problem hiding this comment.
Replacing a workspace dependency with a fixed version ("@backstage/config-loader": "0.1.1") breaks the monorepo's linked development pattern. In a monorepo, workspace dependencies ensure that packages use each other's latest code during development.
This change could:
- Prevent local changes in
config-loaderfrom being reflected in the CLI - Create version conflicts with other packages that expect the workspace version
- Make development and testing more difficult
Consider either:
- Keeping the workspace dependency (
"workspace:^") - Using a version range that includes the current workspace version
- Documenting why this specific fixed version is required
| "@backstage/config-loader": "0.1.1", | |
| "@backstage/config-loader": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/cli/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TARFS-10293725
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Link Resolution Before File Access ('Link Following')
Summary by Sourcery
Upgrade CLI dependencies to remediate three security vulnerabilities flagged by Snyk
Bug Fixes: