Skip to content

[Snyk] Fix for 3 vulnerabilities #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #5299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing a workspace dependency with a fixed version ("@backstage/config-loader": "0.1.1") breaks the monorepo's linked development pattern. In a monorepo, workspace dependencies ensure that packages use each other's latest code during development.

This change could:

  1. Prevent local changes in config-loader from being reflected in the CLI
  2. Create version conflicts with other packages that expect the workspace version
  3. Make development and testing more difficult

Consider either:

  • Keeping the workspace dependency ("workspace:^")
  • Using a version range that includes the current workspace version
  • Documenting why this specific fixed version is required
Suggested change
"@backstage/config-loader": "0.1.1",
"@backstage/config-loader": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
Expand Down Expand Up @@ -131,7 +131,7 @@
"terser-webpack-plugin": "^5.1.3",
"util": "^0.12.3",
"webpack": "^5.70.0",
"webpack-dev-server": "^4.7.3",
"webpack-dev-server": "^5.2.2",
"webpack-node-externals": "^3.0.0",
"yaml": "^2.0.0",
"yml-loader": "^2.1.0",
Expand Down
Loading