Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/org/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change disrupts the monorepo's dependency management pattern. The PR replaces "@backstage/theme": "workspace:^" with a fixed version "0.1.1", while all other Backstage dependencies continue using workspace references.

This approach:

  1. Creates inconsistent dependency resolution
  2. May cause version conflicts within the monorepo
  3. Breaks the workspace pattern that ensures all components use the same versions

Instead of changing the reference pattern for this single package, the security vulnerability should be addressed by updating the @backstage/theme package within the workspace itself. This maintains consistency across the monorepo while still addressing the security concern.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading