Skip to content

[Snyk] Fix for 1 vulnerabilities#5314

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-186b0558cab71a1d7315aa535be35759
Closed

[Snyk] Fix for 1 vulnerabilities#5314
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-186b0558cab71a1d7315aa535be35759

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Jun 3, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/permission-node/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Improper Link Resolution Before File Access ('Link Following')
SNYK-JS-TARFS-10293725
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improper Link Resolution Before File Access ('Link Following')

Summary by Sourcery

Fix a high-severity tar-fs vulnerability by updating key backstage dependencies in the permission-node plugin

Bug Fixes:

  • Address SNYK-JS-TARFS-10293725 (Improper Link Resolution) by upgrading the transitive tar-fs dependency

Enhancements:

  • Pin @backstage/backend-common (0.24.1), @backstage/backend-plugin-api (0.6.19), and @backstage/plugin-auth-node (0.5.0) instead of using workspace references

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jun 3, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 3, 2025

Reviewer's Guide

This PR patches a high-severity TarFS vulnerability by upgrading key Backstage dependencies in the permission-node plugin to specific, fixed versions.

Sequence Diagram: Snyk Automated Vulnerability Fix Process

sequenceDiagram
    actor SnykAutomation as "Snyk Automation"
    participant ProjectRepo as "Project Repository"
    participant PackageFile as "plugins/permission-node/package.json"
    participant VulnerabilityDB as "Snyk Vulnerability DB"

    SnykAutomation->>ProjectRepo: Scan project dependencies
    SnykAutomation->>VulnerabilityDB: Check dependencies against database
    VulnerabilityDB-->>SnykAutomation: Report vulnerability (e.g., SNYK-JS-TARFS-10293725)
    SnykAutomation->>PackageFile: Identify affected dependencies in package.json
    SnykAutomation->>PackageFile: Update versions to fixed versions:
    Note over PackageFile: @backstage/backend-common: workspace:^ -> 0.24.1
    Note over PackageFile: @backstage/backend-plugin-api: workspace:^ -> 0.6.19
    Note over PackageFile: @backstage/plugin-auth-node: workspace:^ -> 0.5.0
    SnykAutomation->>ProjectRepo: Commit updated package.json
    SnykAutomation->>ProjectRepo: Create Pull Request for review
Loading

File-Level Changes

Change Details Files
Upgrade dependency version specifiers to patched releases
  • Bump @backstage/backend-common to 0.24.1
  • Bump @backstage/backend-plugin-api to 0.6.19
  • Bump @backstage/plugin-auth-node to 0.5.0
plugins/permission-node/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented Jun 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Comment on lines +51 to +55
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.5.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency management approach in this PR creates inconsistency by changing only some @backstage dependencies from workspace:^ to specific versions while leaving others with workspace references. This mixed approach can cause dependency resolution issues in monorepo setups.

For proper dependency management, either:

  1. Keep all @backstage dependencies as workspace:^ references (preferred for monorepo development)
  2. Change all to specific versions

The current mixed approach may lead to version conflicts or unexpected behavior when resolving dependencies. Consider standardizing the approach across all @backstage dependencies in this file.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.5.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 10, 2025
@github-actions github-actions Bot closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants