Skip to content

[Snyk] Fix for 1 vulnerabilities #5314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/permission-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.5.0",
Comment on lines +51 to +55
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency management approach in this PR creates inconsistency by changing only some @backstage dependencies from workspace:^ to specific versions while leaving others with workspace references. This mixed approach can cause dependency resolution issues in monorepo setups.

For proper dependency management, either:

  1. Keep all @backstage dependencies as workspace:^ references (preferred for monorepo development)
  2. Change all to specific versions

The current mixed approach may lead to version conflicts or unexpected behavior when resolving dependencies. Consider standardizing the approach across all @backstage dependencies in this file.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.5.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-permission-common": "workspace:^",
"@types/express": "^4.17.6",
"express": "^4.17.1",
Expand Down
Loading