Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace dependency reference workspace:^ with a fixed version 0.1.1, which breaks the monorepo's dependency structure. In a monorepo, workspace references ensure that local versions of packages are used during development rather than versions from the npm registry.

While addressing the security vulnerability is important, changing the dependency format will cause the package to use the external npm version instead of the local workspace version. This can lead to:

  1. Version inconsistencies across the monorepo
  2. Difficulty in testing local changes across packages
  3. Potential build and runtime issues

Consider addressing the security vulnerability while maintaining the workspace reference format. This might involve updating the local package version while keeping the workspace:^ syntax intact.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"lodash": "^4.17.21"
},
"devDependencies": {
Expand Down
Loading