Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/analytics-module-newrelic-browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace dependency with a fixed version, which breaks the monorepo's dependency management pattern. In a Backstage monorepo, dependencies between internal packages should use workspace:^ to ensure consistent versioning across the codebase.

While addressing the security vulnerability is important, changing to a fixed version 0.1.0 will:

  1. Pull the package from the npm registry instead of using the local version
  2. Potentially cause version conflicts with other components
  3. Make future updates more difficult to manage

Consider addressing the security vulnerability while maintaining the workspace reference pattern. This might involve updating the vulnerable dependency within your local @backstage/core-components package instead.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-components": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/core-plugin-api": "workspace:^",
"@newrelic/browser-agent": "^1.236.0",
"react-use": "^17.2.4"
Expand Down
Loading