Skip to content

[Snyk] Fix for 1 vulnerabilities #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/jenkins-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-jenkins-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +27 to +35
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete as it modifies package references without updating the corresponding yarn.lock file, as noted in the warning section of the PR description.

The dependency updates also show inconsistency - some Backstage packages are being pinned to specific versions (like @backstage/backend-common: "0.24.1") while others remain as workspace references (workspace:^). This mixed approach could lead to compatibility issues between the Backstage components.

For a proper fix, either:

  1. All related Backstage dependencies should be pinned to specific compatible versions, or
  2. All should maintain workspace references to ensure version alignment

Without addressing the yarn.lock update and dependency consistency issues, this PR may introduce more problems than it solves, despite addressing the security vulnerability.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading