Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/search-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"dependencies": {
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a dependency inconsistency by replacing the workspace reference with a specific version number. In a monorepo setup where other packages use workspace:^ references, switching just one dependency to a fixed version (0.1.1) breaks the consistency pattern and can lead to versioning problems.

The security vulnerability should be addressed by updating the @backstage/types package within the workspace rather than bypassing the workspace reference. This maintains the monorepo's dependency management approach while still addressing the security concern.

Consider updating the vulnerable dependency in its source location instead of changing how it's referenced here.

Suggested change
"@backstage/types": "0.1.1"
"@backstage/types": "workspace:^"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading