Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/explore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-explore-react": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-search-react": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace dependency pattern (workspace:^) with a hardcoded version (0.1.0), which breaks the monorepo dependency management approach used in Backstage.

In Backstage monorepos, internal packages should reference each other using workspace:^ to ensure they use the local versions during development. This maintains consistency and prevents version conflicts.

Instead of changing how the package is referenced, the security fix should be applied to the @backstage/plugin-search-react package itself.

Hardcoding the version this way could lead to:

  • Version conflicts with other packages
  • Build failures
  • Difficulty tracking dependencies
  • Issues during development when local changes aren't picked up

Consider addressing the vulnerability by updating the actual package rather than modifying how it's referenced.

Suggested change
"@backstage/plugin-search-react": "0.1.0",
"@backstage/plugin-search-react": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading