Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces the workspace dependency pattern (
workspace:^) with a hardcoded version (0.1.0), which breaks the monorepo dependency management approach used in Backstage.In Backstage monorepos, internal packages should reference each other using
workspace:^to ensure they use the local versions during development. This maintains consistency and prevents version conflicts.Instead of changing how the package is referenced, the security fix should be applied to the
@backstage/plugin-search-reactpackage itself.Hardcoding the version this way could lead to:
Consider addressing the vulnerability by updating the actual package rather than modifying how it's referenced.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.