Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/github-deployments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a potential dependency management issue by replacing the workspace reference (workspace:^) with a fixed version (0.1.1) from an external registry. In a monorepo structure, this inconsistency can lead to:

  1. Version conflicts when multiple components require different versions of the same package
  2. Duplicate package installations increasing bundle size
  3. Potential runtime compatibility issues

To address the security vulnerability while maintaining monorepo integrity, consider:

  • Updating the vulnerable dependency within your workspace
  • Ensuring all @backstage packages use consistent reference patterns

The security fix is important, but implementing it in a way that preserves the monorepo's dependency management approach will prevent future integration problems.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading