Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/scaffolder-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace dependency workspace:^ with a fixed version 0.1.1, which breaks the monorepo's dependency management pattern. Using a fixed version instead of the workspace reference will:

  1. Pull the package from npm rather than using the local version
  2. Potentially create type inconsistencies between packages
  3. Make it harder to develop and test changes across packages

To maintain proper workspace linking and consistency across the monorepo, the dependency should remain as workspace:^. This ensures that local development works correctly and that all packages use compatible versions of shared dependencies.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading