Skip to content

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1#5399

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-a3aeabd55e6f1c2d2d48731fc409624f
Closed

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1#5399
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-a3aeabd55e6f1c2d2d48731fc409624f

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Jun 4, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/periskop/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Improper Link Resolution Before File Access ('Link Following')
SNYK-JS-TARFS-10293725
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improper Link Resolution Before File Access ('Link Following')

Summary by Sourcery

Bug Fixes:

  • Upgrade @backstage/theme from local workspace to version 0.1.1 to fix an improper link resolution vulnerability

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jun 4, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 4, 2025

Reviewer's Guide

This PR upgrades the @backstage/theme dependency in the periskop plugin from a local workspace reference to version 0.1.1 to remediate a high-severity vulnerability, and notes that the yarn.lock must be updated manually before merging.

Sequence Diagram: Required Manual yarn.lock Update Process

sequenceDiagram
    actor Developer
    participant LocalWorkspace as "Local Workspace (with PR changes)"
    participant YarnCLI as "Yarn CLI"
    participant YarnLock as "yarn.lock file"
    participant RemoteRepo as "Remote Repository"

    Developer->>LocalWorkspace: Checkout PR branch / Pull changes
    Developer->>YarnCLI: Executes `yarn install` (or equivalent)
    YarnCLI->>YarnLock: Updates yarn.lock
    YarnLock-->>YarnCLI: Confirms update
    YarnCLI-->>Developer: Reports completion
    Developer->>LocalWorkspace: Stages updated yarn.lock
    Developer->>RemoteRepo: Commits and Pushes changes (including yarn.lock)
    Note over Developer,RemoteRepo: PR can now be merged with correct yarn.lock
Loading

File-Level Changes

Change Details Files
Bump @backstage/theme dependency version
  • Removed workspace:^ reference for @backstage/theme
  • Set @backstage/theme to version 0.1.1
plugins/periskop/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented Jun 4, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 11, 2025
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces inconsistency in dependency management by using a fixed version (0.1.1) for @backstage/theme while other Backstage dependencies use workspace references (workspace:^). In monorepo setups, mixing versioning strategies can lead to dependency resolution conflicts and maintenance challenges. Consider maintaining consistency by either:

  1. Upgrading the workspace version of @backstage/theme to address the vulnerability
  2. Using a resolutions field in the root package.json to patch the vulnerability while maintaining workspace references

This approach would preserve the monorepo's dependency consistency while addressing the security concern.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions github-actions Bot removed the stale label Jun 11, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 18, 2025
@github-actions github-actions Bot closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants