Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/periskop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces inconsistency in dependency management by using a fixed version (0.1.1) for @backstage/theme while other Backstage dependencies use workspace references (workspace:^). In monorepo setups, mixing versioning strategies can lead to dependency resolution conflicts and maintenance challenges. Consider maintaining consistency by either:

  1. Upgrading the workspace version of @backstage/theme to address the vulnerability
  2. Using a resolutions field in the root package.json to patch the vulnerability while maintaining workspace references

This approach would preserve the monorepo's dependency consistency while addressing the security concern.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading