Skip to content

[Snyk] Fix for 1 vulnerabilities #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/techdocs-cli-embedded-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
"@backstage/cli": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
Comment on lines +15 to +19
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces dependency management inconsistency by replacing workspace:^ references with fixed, outdated versions (0.1.0, 0.1.1). In a monorepo, mixing workspace references with pinned versions disrupts the dependency resolution system and can create compatibility issues with other packages that continue using workspace references.

The warning in the PR description ("Failed to update the yarn.lock") further indicates that this approach may not properly resolve the security vulnerability.

A more appropriate solution would be to maintain the workspace:^ references while updating the vulnerable dependencies at their source within the monorepo. This preserves the integrity of the workspace dependency model while addressing the security concern.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
Expand Down
Loading