Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/github-issues/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace reference with a fixed version, which breaks the monorepo dependency pattern. The other @backstage dependencies use workspace:^ to ensure consistent versioning within the project, while this change pins to a specific version 0.1.0 (which appears to be quite old for Backstage packages).

While addressing security vulnerabilities is important, changing the dependency resolution pattern may introduce other issues:

  1. It creates inconsistency in how dependencies are managed
  2. It may cause version conflicts during dependency resolution
  3. The fixed version might not be compatible with other workspace packages

Consider either:

  • Maintaining the workspace:^ pattern and updating the dependency in the workspace root
  • If a specific version is required for security reasons, verify that 0.1.0 is appropriate and document the exception

The warning about failing to update yarn.lock in the PR description suggests additional manual intervention will be needed before merging.

Suggested change
"@backstage/integration": "0.1.0",
"@backstage/integration": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.4",
Expand Down
Loading