Skip to content

[Snyk] Fix for 3 vulnerabilities #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #5438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/example-todo-list-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.5.0",
Comment on lines +27 to +31
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace references with fixed versions disrupts the monorepo dependency management pattern. This approach can lead to version conflicts since the PR description indicates the yarn.lock update failed.

A more effective approach would be to:

  1. Keep the workspace:^ references intact
  2. Update the vulnerable packages in the root package.json instead
  3. Run yarn to regenerate the lockfile properly

This maintains the monorepo integrity while still addressing the security vulnerabilities identified by Snyk.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.5.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading