Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/fossa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a dependency inconsistency that could lead to compatibility issues. Changing @backstage/theme from workspace:^ to a fixed version 0.1.1 while keeping other Backstage packages as workspace dependencies creates a mixed dependency pattern in the monorepo.

In monorepo setups, consistent dependency resolution is important - either all related packages should use workspace references or all should use specific versions. This inconsistency might cause:

  1. Version conflicts during dependency resolution
  2. Unexpected behavior if the workspace version differs from 0.1.1
  3. Maintenance challenges when updating related packages

Consider either:

  • Keeping @backstage/theme as workspace:^ to maintain consistency with other Backstage dependencies
  • Converting all Backstage dependencies to specific versions if there's a reason to pin this particular package
Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading