Skip to content

[Snyk] Fix for 2 vulnerabilities #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #5583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/config-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"dependencies": {
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/types": "0.1.1",
Comment on lines +38 to +39
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed version dependencies, which breaks the monorepo's dependency management system. In a monorepo, workspace:^ ensures packages use local versions during development, maintaining consistency across the codebase.

Fixed versions (0.1.1) will pull from npm instead of using local code, potentially causing:

  • Version mismatches between packages
  • Difficulty testing local changes across packages
  • Inconsistent behavior between development and production

To properly address the webpack-dev-server vulnerabilities while maintaining monorepo integrity:

  1. Update the vulnerable dependencies in their source packages
  2. Keep the workspace:^ references intact
  3. Update the root package.json or yarn.lock with the patched versions

This ensures the security fixes propagate through the workspace references while preserving the monorepo structure.

Suggested change
"@backstage/errors": "0.1.1",
"@backstage/types": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/json-schema": "^7.0.6",
"ajv": "^8.10.0",
"chokidar": "^3.5.2",
Expand Down
Loading