Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/catalog-unprocessed-entities/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces inconsistency in dependency management by mixing a specific version (0.1.1) with workspace references (workspace:^) for Backstage packages. In a monorepo setup, this inconsistency can lead to version conflicts and runtime errors when packages expect compatible versions of their dependencies.

For maintainability and to prevent potential issues, it's recommended to use a consistent approach throughout the project - either all Backstage packages should use workspace references or all should use specific versions.

Consider keeping the workspace reference pattern:

"@backstage/theme": "workspace:^",

This ensures that the package will always use the version available in the workspace, maintaining consistency with other Backstage dependencies.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.60",
Expand Down
Loading