Skip to content

[Snyk] Fix for 4 vulnerabilities #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 4 vulnerabilities #5587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/todo-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-openapi-utils": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-openapi-utils": "0.0.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +32 to +40
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces inconsistent dependency management by mixing specific version numbers with workspace references (workspace:^). In a monorepo architecture, this approach can lead to version conflicts and dependency resolution issues.

The change converts some dependencies to fixed versions:

"@backstage/backend-common": "0.24.1",
"@backstage/backend-openapi-utils": "0.0.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-catalog-node": "1.0.0",

While leaving others as workspace references:

"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",

For monorepo stability, consider either:

  1. Keeping all Backstage dependencies as workspace references
  2. Converting all Backstage dependencies to specific versions

This ensures consistent dependency resolution throughout the project.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-openapi-utils": "0.0.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-openapi-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading