Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/kafka/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the workspace reference workspace:^ with a hardcoded version 0.1.0 for the @backstage/core-plugin-api dependency. This breaks the monorepo workspace structure, which could lead to:

  1. Using an external package instead of the local workspace version
  2. Potential version conflicts with other Backstage components
  3. Build and runtime issues due to mismatched dependencies

To maintain consistency with the project's monorepo structure, the dependency should remain as:

"@backstage/core-plugin-api": "workspace:^",

If security vulnerabilities need addressing, consider upgrading the core package version within the workspace rather than bypassing the workspace reference.

Suggested change
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading