Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/search-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change deviates from the project's dependency management pattern. All other @backstage/* packages in this file use the workspace:^ syntax, which is important for monorepo consistency. Pinning to a specific version (0.1.1) could lead to version conflicts and break the workspace resolution mechanism.

Instead of modifying this individual package, consider addressing the security vulnerabilities at the workspace root level, which would propagate the fix throughout the monorepo while maintaining the consistent dependency pattern.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading