[Snyk] Fix for 2 vulnerabilities#5611
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300775 - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300777
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThis PR upgrades two Backstage workspace dependencies to fixed versions to address high- and medium-severity vulnerabilities and surfaces a manual lockfile update requirement. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
| "@backstage/core-app-api": "0.1.0", | ||
| "@backstage/core-components": "workspace:^", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/plugin-permission-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
This PR introduces a problematic approach to dependency management in a monorepo. Replacing workspace references (workspace:^) with pinned versions (0.1.0 and 0.1.1) breaks the internal dependency structure that workspace references are designed to maintain. These specific versions appear to be quite old and likely incompatible with the current codebase.
The warning in the PR description that "Failed to update the yarn.lock" is a significant red flag - this confirms the changes will cause dependency resolution issues.
A better approach would be to:
- Update the vulnerable dependencies within the workspace
- Maintain the
workspace:^references - Ensure the yarn.lock file is properly updated
Consider rejecting this PR and addressing the vulnerabilities by upgrading the affected packages within your workspace structure instead.
| "@backstage/core-app-api": "0.1.0", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/plugin-permission-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/theme": "0.1.1", | |
| "@backstage/core-app-api": "workspace:^", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/plugin-permission-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/app-defaults/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACKDEVSERVER-10300775
SNYK-JS-WEBPACKDEVSERVER-10300777
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Sourcery
Fix high and medium severity vulnerabilities by upgrading core-app dependencies
Bug Fixes: