Skip to content

[Snyk] Fix for 3 vulnerabilities#5620

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-e37ec0f9159956f796bd8eaa7f494d9d
Closed

[Snyk] Fix for 3 vulnerabilities#5620
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-e37ec0f9159956f796bd8eaa7f494d9d

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Jun 5, 2025

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/scaffolder-backend-module-rails/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Origin Validation Error
SNYK-JS-WEBPACKDEVSERVER-10300775
  748  
critical severity Uncaught Exception
SNYK-JS-MULTER-10299078
  746  
medium severity Exposed Dangerous Method or Function
SNYK-JS-WEBPACKDEVSERVER-10300777
  693  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Uncaught Exception

Summary by Sourcery

Bug Fixes:

  • Bump @backstage/backend-common to 0.24.1, @backstage/integration to 0.1.0, @backstage/plugin-scaffolder-backend to 1.24.0, and @backstage/plugin-scaffolder-node to 0.4.5 to address high- and critical-severity issues in webpack-dev-server and multer.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Jun 5, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 5, 2025

Reviewer's Guide

This PR addresses three security vulnerabilities by updating the plugins/scaffolder-backend-module-rails package’s dependencies: replacing workspace-based versions with explicit, patched releases of key Backstage packages.

Flow Diagram: Snyk Vulnerability Fix Process for scaffolder-backend-module-rails

graph TD
    A[Snyk: Identifies Vulnerabilities in Dependencies] --> B["Snyk: Creates PR with package.json Updates for<br>plugins/scaffolder-backend-module-rails"];
    B --> C["<strong>Updated Dependencies in package.json:</strong><br>- @backstage/backend-common: workspace:^ &rarr; 0.24.1<br>- @backstage/integration: workspace:^ &rarr; 0.1.0<br>- @backstage/plugin-scaffolder-backend: workspace:^ &rarr; 1.24.0<br>- @backstage/plugin-scaffolder-node: workspace:^ &rarr; 0.4.5"];
    B --> D["<strong>PR Warning:</strong><br>yarn.lock not automatically updated"];
    D --> E[Developer: Review PR Changes];
    E --> F[Developer: Manually run 'yarn' to update yarn.lock];
    F --> G[Developer: Commit updated yarn.lock];
    G --> H[Developer: Merge PR];
    H --> I[Vulnerabilities Addressed & Dependencies Updated];
Loading

File-Level Changes

Change Details Files
Upgrade several @backstage dependencies to fixed versions
  • @backstage/backend-common set to 0.24.1 instead of workspace:^
  • @backstage/integration set to 0.1.0 instead of workspace:^
  • @backstage/plugin-scaffolder-backend set to 1.24.0 instead of workspace:^
  • @backstage/plugin-scaffolder-node set to 0.4.5 instead of workspace:^
plugins/scaffolder-backend-module-rails/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented Jun 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Comment on lines +26 to +31
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.4.5",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace:^ to specific version numbers breaks the monorepo dependency structure. In a Yarn workspace setup, workspace:^ references indicate local packages within the same repository, ensuring that local development versions are used.

Replacing these with fixed versions (0.24.1, 0.1.0, etc.) forces package resolution from the npm registry instead of using local workspace packages. This will likely cause build failures and inconsistencies between packages.

While addressing the vulnerabilities is important, the fix should maintain the workspace references. Consider updating the vulnerable dependencies in their source packages within the monorepo instead of changing the reference style in this package.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.4.5",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Jun 12, 2025
@github-actions github-actions Bot closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants