Skip to content

[Snyk] Fix for 3 vulnerabilities #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #5620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-backend-module-rails/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.4.5",
Comment on lines +26 to +31
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace:^ to specific version numbers breaks the monorepo dependency structure. In a Yarn workspace setup, workspace:^ references indicate local packages within the same repository, ensuring that local development versions are used.

Replacing these with fixed versions (0.24.1, 0.1.0, etc.) forces package resolution from the npm registry instead of using local workspace packages. This will likely cause build failures and inconsistencies between packages.

While addressing the vulnerabilities is important, the fix should maintain the workspace references. Consider updating the vulnerable dependencies in their source packages within the monorepo instead of changing the reference style in this package.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "1.24.0",
"@backstage/plugin-scaffolder-node": "0.4.5",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"command-exists": "^1.2.9",
"fs-extra": "^10.0.1"
Expand Down
Loading