Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/github-deployments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing a workspace dependency with a fixed version (0.1.1) breaks the workspace resolution pattern used throughout the project. This approach:

  1. Creates potential compatibility issues with other Backstage packages that expect consistent versioning
  2. May introduce runtime errors if version 0.1.1 is incompatible with other dependencies
  3. Is incomplete without corresponding yarn.lock updates (which failed according to the PR description)

For security upgrades, consider updating the vulnerable dependency within the workspace pattern instead, maintaining workspace:^ while ensuring the resolved version addresses the vulnerabilities. This preserves the project's dependency management approach while fixing the security issues.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading