Skip to content

[Snyk] Fix for 2 vulnerabilities #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #5633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/scaffolder-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/types": "0.1.1",
Comment on lines +29 to +30
Copy link
Copy Markdown

@graphite-app graphite-app Bot Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references (workspace:^) with fixed versions, which breaks the monorepo's local development setup. In a workspace-based project, these references ensure packages use local development versions rather than published npm packages.

The warning about failing to update yarn.lock further indicates potential dependency resolution problems.

Recommendation:

  1. Retain the original workspace:^ references
  2. If security fixes are needed, update the vulnerable dependencies within the workspace
  3. Ensure yarn.lock is properly updated before merging

This approach maintains the integrity of the monorepo while addressing the security vulnerabilities in webpack-dev-server.

Suggested change
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/types": "0.1.1",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"jsonschema": "^1.2.6",
"winston": "^3.2.1",
"zod": "^3.21.4",
Expand Down
Loading