Skip to content

fix(deps): update dependency @octokit/request to v8 [security]#7366

Closed
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-octokit-request-vulnerability
Closed

fix(deps): update dependency @octokit/request to v8 [security]#7366
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-octokit-request-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented Aug 13, 2025

Note

Mend has cancelled the proposed renaming of the Renovate GitHub app being renamed to mend[bot].

This notice will be removed on 2025-10-07.


This PR contains the following updates:

Package Change Age Confidence
@octokit/request ^6.0.0 -> ^8.0.0 age confidence

GitHub Vulnerability Alerts

CVE-2025-25290

Summary

The regular expression /<([^>]+)>; rel="deprecation"/ used to match the link header in HTTP responses is vulnerable to a ReDoS (Regular Expression Denial of Service) attack. This vulnerability arises due to the unbounded nature of the regex's matching behavior, which can lead to catastrophic backtracking when processing specially crafted input. An attacker could exploit this flaw by sending a malicious link header, resulting in excessive CPU usage and potentially causing the server to become unresponsive, impacting service availability.

Details

The vulnerability resides in the regular expression /<([^>]+)>; rel="deprecation"/, which is used to match the link header in HTTP responses. This regular expression captures content between angle brackets (<>) followed by ; rel="deprecation". However, the pattern is vulnerable to ReDoS (Regular Expression Denial of Service) attacks due to its susceptibility to catastrophic backtracking when processing malicious input.
An attacker can exploit this vulnerability by sending a specially crafted link header designed to trigger excessive backtracking. For example, the following headers:

fakeHeaders.set("link", "<".repeat(100000) + ">");
fakeHeaders.set("deprecation", "true");

The crafted link header consists of 100,000 consecutive < characters followed by a closing >. This input forces the regular expression engine to backtrack extensively in an attempt to match the pattern. As a result, the server can experience a significant increase in CPU usage, which may lead to denial of service, making the server unresponsive or even causing it to crash under load.
The issue is present in the following code:

const matches = responseHeaders.link && responseHeaders.link.match(/<([^>]+)>; rel="deprecation"/);

In this scenario, the link header value triggers the regex to perform excessive backtracking, resulting in resource exhaustion and potentially causing the service to become unavailable.

PoC

The gist of PoC.js

  1. run npm i @​octokit/request
  2. run 'node poc.js'
    result:
  3. then the program will stuck forever with high CPU usage
import { request } from "@&#8203;octokit/request";
const originalFetch = globalThis.fetch;
globalThis.fetch = async (url, options) => {
  const response = await originalFetch(url, options);
  const fakeHeaders = new Headers(response.headers);
  fakeHeaders.set("link", "<".repeat(100000) + ">");
  fakeHeaders.set("deprecation", "true");
  return new Response(response.body, {
    status: response.status,
    statusText: response.statusText,
    headers: fakeHeaders
  });
};
request("GET /repos/octocat/hello-world")
  .then(response => {
    // console.log("[+] Response received:", response);
  })
  .catch(error => {
    // console.error("[-] Error:", error);
  });
// globalThis.fetch = originalFetch;

Impact

This is a Denial of Service (DoS) vulnerability caused by a ReDoS (Regular Expression Denial of Service) flaw. The vulnerability allows an attacker to craft a malicious link header that exploits the inefficient backtracking behavior of the regular expression used in the code.
The primary impact is the potential for server resource exhaustion, specifically high CPU usage, which can cause the server to become unresponsive or even crash when processing the malicious request. This affects the availability of the service, leading to downtime or degraded performance.
The vulnerability impacts any system that uses this specific regular expression to process link headers in HTTP responses. This can include:

  • Web applications or APIs that rely on parsing headers for deprecation information.
  • Users interacting with the affected service, as they may experience delays or outages if the server becomes overwhelmed.
  • Service providers who may face disruption in operations or performance degradation due to this flaw.
    If left unpatched, the vulnerability can be exploited by any unauthenticated user who is able to send a specially crafted HTTP request with a malicious link header, making it a low-barrier attack that could be exploited by anyone.

Release Notes

octokit/request.js (@​octokit/request)

v8.4.1

Compare Source

Bug Fixes

v8.4.0

Compare Source

Features

v8.3.1

Compare Source

Bug Fixes
  • upgrade @octokit/endpoint (4e7127c)

v8.3.0

Compare Source

Bug Fixes
Features

v8.2.0

Compare Source

Features

v8.1.6

Compare Source

Bug Fixes

v8.1.5

Compare Source

Bug Fixes

v8.1.4

Compare Source

Bug Fixes
  • error.cause from undici may be instance of Error (#​643) (c67f902)

v8.1.3

Compare Source

Bug Fixes

v8.1.2

Compare Source

Bug Fixes

v8.1.1

Compare Source

Bug Fixes
  • fetch-wrapper: improve error message when 'fetch' implementation is not present (#​617) (a83722c)

v8.1.0

Compare Source

Features

v8.0.4

Compare Source

Bug Fixes

v8.0.3

Compare Source

Bug Fixes

v8.0.2

Compare Source

Bug Fixes

v8.0.1

Compare Source

Bug Fixes

v8.0.0

Compare Source

Features
BREAKING CHANGES
  • Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead
  • Remove ability to pass custom request options, except from method, headers, body, signal, data

v7.0.1

Compare Source

Bug Fixes

v7.0.0

Compare Source

Features
BREAKING CHANGES
  • Drop support for NodeJS v14, v16

  • remove node-fetch in favor of global

  • docs: update ToC for README.md


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added the dependencies Pull requests that update a dependency file label Aug 13, 2025
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Aug 13, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Aug 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Aug 13, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Aug 13, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Aug 20, 2025
@renovate renovate Bot force-pushed the renovate/npm-octokit-request-vulnerability branch from 3dab746 to 74dbaf9 Compare August 21, 2025 04:40
@github-actions github-actions Bot removed the stale label Aug 21, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Aug 28, 2025
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate Bot force-pushed the renovate/npm-octokit-request-vulnerability branch from 74dbaf9 to cea357c Compare September 1, 2025 01:21
@github-actions github-actions Bot removed the stale label Sep 3, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added stale and removed stale labels Sep 10, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Sep 22, 2025
@github-actions github-actions Bot closed this Sep 30, 2025
@renovate
Copy link
Copy Markdown
Author

renovate Bot commented Sep 30, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 8.x releases. But if you manually upgrade to 8.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate Bot deleted the renovate/npm-octokit-request-vulnerability branch September 30, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants