Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build-storybook": "build-storybook --output-dir dist"
},
"dependencies": {
"@swc/core": "^1.3.46",
"@swc/core": "^1.13.20",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🚨 Version Mismatch Risk: The package.json specifies ^1.13.20 but yarn.lock resolves to 1.14.0. This could lead to inconsistent behavior across different environments where different team members may get different SWC versions.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@swc/core": "^1.13.20",
"@swc/core": "1.14.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🚨 Major Version Jump Without Gradual Migration: Jumping from 1.3.46 to 1.13.20 spans multiple major releases with potential breaking changes. SWC has had documented breaking changes in AST definitions and plugin compatibility that could break existing builds, transformations, or plugin compatibility.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: ⚠️ Missing Changelog/Migration Documentation: No documentation provided about why this upgrade is needed or what it addresses. Team members won't understand potential breaking changes or the business need for this upgrade.

"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-hot-loader": "^4.13.0",
Expand Down
112 changes: 65 additions & 47 deletions storybook/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2840,92 +2840,94 @@ __metadata:
languageName: node
linkType: hard

"@swc/core-darwin-arm64@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-darwin-arm64@npm:1.3.68"
"@swc/core-darwin-arm64@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-darwin-arm64@npm:1.14.0"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

"@swc/core-darwin-x64@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-darwin-x64@npm:1.3.68"
"@swc/core-darwin-x64@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-darwin-x64@npm:1.14.0"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard

"@swc/core-linux-arm-gnueabihf@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm-gnueabihf@npm:1.3.68"
"@swc/core-linux-arm-gnueabihf@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm-gnueabihf@npm:1.14.0"
conditions: os=linux & cpu=arm
Comment on lines +2843 to 2860
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: ⚠️ New Dependencies Added: @swc/counter and @swc/types are now required dependencies. This increases bundle size and introduces potential supply chain risk. These dependencies should be verified as legitimate and audited for security.

Comment on lines +2843 to 2860
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: ⚠️ Peer Dependency Compatibility: @swc/helpers requirement changed from ^0.5.0 to >=0.5.17. This may require updates to other packages using SWC helpers and could impact compatibility across the Backstage monorepo.

languageName: node
linkType: hard

"@swc/core-linux-arm64-gnu@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm64-gnu@npm:1.3.68"
"@swc/core-linux-arm64-gnu@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm64-gnu@npm:1.14.0"
conditions: os=linux & cpu=arm64 & libc=glibc
languageName: node
linkType: hard

"@swc/core-linux-arm64-musl@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm64-musl@npm:1.3.68"
"@swc/core-linux-arm64-musl@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm64-musl@npm:1.14.0"
conditions: os=linux & cpu=arm64 & libc=musl
languageName: node
linkType: hard

"@swc/core-linux-x64-gnu@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-x64-gnu@npm:1.3.68"
"@swc/core-linux-x64-gnu@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-x64-gnu@npm:1.14.0"
conditions: os=linux & cpu=x64 & libc=glibc
languageName: node
linkType: hard

"@swc/core-linux-x64-musl@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-x64-musl@npm:1.3.68"
"@swc/core-linux-x64-musl@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-x64-musl@npm:1.14.0"
conditions: os=linux & cpu=x64 & libc=musl
languageName: node
linkType: hard

"@swc/core-win32-arm64-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-arm64-msvc@npm:1.3.68"
"@swc/core-win32-arm64-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-arm64-msvc@npm:1.14.0"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard

"@swc/core-win32-ia32-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-ia32-msvc@npm:1.3.68"
"@swc/core-win32-ia32-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-ia32-msvc@npm:1.14.0"
conditions: os=win32 & cpu=ia32
languageName: node
linkType: hard

"@swc/core-win32-x64-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-x64-msvc@npm:1.3.68"
"@swc/core-win32-x64-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-x64-msvc@npm:1.14.0"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard

"@swc/core@npm:^1.3.46":
version: 1.3.68
resolution: "@swc/core@npm:1.3.68"
"@swc/core@npm:^1.13.20":
version: 1.14.0
resolution: "@swc/core@npm:1.14.0"
dependencies:
"@swc/core-darwin-arm64": 1.3.68
"@swc/core-darwin-x64": 1.3.68
"@swc/core-linux-arm-gnueabihf": 1.3.68
"@swc/core-linux-arm64-gnu": 1.3.68
"@swc/core-linux-arm64-musl": 1.3.68
"@swc/core-linux-x64-gnu": 1.3.68
"@swc/core-linux-x64-musl": 1.3.68
"@swc/core-win32-arm64-msvc": 1.3.68
"@swc/core-win32-ia32-msvc": 1.3.68
"@swc/core-win32-x64-msvc": 1.3.68
"@swc/core-darwin-arm64": 1.14.0
"@swc/core-darwin-x64": 1.14.0
"@swc/core-linux-arm-gnueabihf": 1.14.0
"@swc/core-linux-arm64-gnu": 1.14.0
"@swc/core-linux-arm64-musl": 1.14.0
"@swc/core-linux-x64-gnu": 1.14.0
"@swc/core-linux-x64-musl": 1.14.0
"@swc/core-win32-arm64-msvc": 1.14.0
"@swc/core-win32-ia32-msvc": 1.14.0
"@swc/core-win32-x64-msvc": 1.14.0
"@swc/counter": ^0.1.3
"@swc/types": ^0.1.25
peerDependencies:
"@swc/helpers": ^0.5.0
"@swc/helpers": ">=0.5.17"
dependenciesMeta:
"@swc/core-darwin-arm64":
optional: true
Expand All @@ -2950,7 +2952,23 @@ __metadata:
peerDependenciesMeta:
"@swc/helpers":
optional: true
checksum: f56ad1d4cb91f7cc1cb5d4b9894bbb528da0b2eabc98984581f5b3f3187cf2c0d512003880f6ff7a3f6d215b7a3dcbf5a9c45e8a428ac2d711941027c0151d89
checksum: 107f3e9f3655b5011db2a5d1816331a241a99488088db9ae3b715bde11219776935e77ab0a47ad4d44c5f799ebafceb34d1e4c547c8af56dc12b9e6feec2d397
languageName: node
linkType: hard

"@swc/counter@npm:^0.1.3":
version: 0.1.3
resolution: "@swc/counter@npm:0.1.3"
checksum: df8f9cfba9904d3d60f511664c70d23bb323b3a0803ec9890f60133954173047ba9bdeabce28cd70ba89ccd3fd6c71c7b0bd58be85f611e1ffbe5d5c18616598
languageName: node
linkType: hard

"@swc/types@npm:^0.1.25":
version: 0.1.25
resolution: "@swc/types@npm:0.1.25"
dependencies:
"@swc/counter": ^0.1.3
checksum: 8e8ec73913aa42ee574c2a5a95fb6a95f19c5f011e66ed3faf773aa26f731e3f9a8b8e4d9e1887124166504253ee9e16d87f292e0ea1411d6170a4d1b327ba25
languageName: node
linkType: hard

Expand Down Expand Up @@ -10665,7 +10683,7 @@ __metadata:
"@storybook/node-logger": ^6.5.9
"@storybook/react": ^6.5.9
"@storybook/testing-library": ^0.2.0
"@swc/core": ^1.3.46
"@swc/core": ^1.13.20
react: ^17.0.2
react-dom: ^17.0.2
react-hot-loader: ^4.13.0
Expand Down Expand Up @@ -11214,7 +11232,7 @@ __metadata:

"typescript@patch:typescript@~4.7.0#~builtin<compat/typescript>":
version: 4.7.4
resolution: "typescript@patch:typescript@npm%3A4.7.4#~builtin<compat/typescript>::version=4.7.4&hash=a1c5e5"
resolution: "typescript@patch:typescript@npm%3A4.7.4#~builtin<compat/typescript>::version=4.7.4&hash=701156"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
Expand Down
Loading