-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 12.0.5 to 15.5.10 #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-dad1f01d2c6963e06ab3314862ca2643
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This major version upgrade from
^12.0.5to^15.5.10will introduce significant breaking changes and is highly likely to break the application. The Snyk report itself flags this as a breaking change.Key issues include:
React Version Incompatibility: Next.js v13 and later versions require React 18. This project currently uses React 17. The build will fail without upgrading
reactandreact-domand adapting the code to React 18's new features, like the root API.Deprecated
next.config.jsOptions: Yournext.config.jsuses options liketarget: 'experimental-serverless-trace'and thefuture.webpack5flag, which are deprecated or removed in newer Next.js versions. These will need to be updated to their modern equivalents (e.g., theoutputoption).Suspicious Target Version: The target version
15.5.10is questionable, as the latest stable Next.js version is v14.x. The vulnerability this PR aims to fix (SNYK-JS-NEXT-15104645) is patched in version14.1.1.Due to these issues, a direct merge is not feasible. A manual migration, carefully addressing the breaking changes between major Next.js versions (12 -> 13 -> 14), is required.