Skip to content

Commit b580ac8

Browse files
authored
Merge pull request evidence-dev#2950 from ismailsunni/next
Handle neverShowQueries inside the KebabMenu component.
2 parents d7a9b8d + d568f74 commit b580ac8

4 files changed

Lines changed: 229 additions & 238 deletions

File tree

.changeset/nasty-pumas-wait.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@evidence-dev/core-components': patch
3+
---
4+
5+
Dont hide entire kebab menu when neverShowQueries is true

packages/ui/core-components/src/lib/organisms/layout/header/Header.svelte

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<script>
2-
import { dev } from '$app/environment';
32
import { Icon } from '@steeze-ui/svelte-icon';
43
import { X, Menu2 } from '@steeze-ui/tabler-icons';
54
import { addBasePath } from '@evidence-dev/sdk/utils/svelte';
@@ -118,9 +117,7 @@
118117
{/if}
119118
</div>
120119
<div class="relative">
121-
{#if dev || !neverShowQueries}
122-
<KebabMenu />
123-
{/if}
120+
<KebabMenu {neverShowQueries} />
124121
</div>
125122
</div>
126123
</div>

packages/ui/core-components/src/lib/organisms/layout/header/KebabMenu.svelte

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
}
2727
2828
const { selectedAppearance, activeAppearance, cycleAppearance, themesConfig } = getThemeStores();
29+
30+
export let neverShowQueries;
31+
2932
$: themeLabel =
3033
$selectedAppearance === 'system'
3134
? 'System'
@@ -47,14 +50,17 @@
4750
Print PDF
4851
<DropdownMenu.Shortcut>⌘P</DropdownMenu.Shortcut>
4952
</DropdownMenu.Item>
50-
<DropdownMenu.Item
51-
on:click={(e) => {
52-
e.preventDefault();
53-
showQueries.update((val) => !val);
54-
}}
55-
>
56-
{$showQueries ? 'Hide ' : 'Show '} Queries
57-
</DropdownMenu.Item>
53+
{#if dev || !neverShowQueries}
54+
<DropdownMenu.Item
55+
on:click={(e) => {
56+
e.preventDefault();
57+
showQueries.update((val) => !val);
58+
}}
59+
>
60+
{$showQueries ? 'Hide ' : 'Show '} Queries
61+
</DropdownMenu.Item>
62+
{/if}
63+
5864
{#if themesConfig.appearance.switcher}
5965
<DropdownMenu.Item
6066
on:click={(e) => {

0 commit comments

Comments
 (0)