Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@rails/ujs": "^6.0.0",
"@rails/webpacker": "5.4.3",
"turbolinks": "^5.2.0",
"webpack": "^4.46.0",
"webpack": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading to Webpack 5 is incompatible with @rails/webpacker v5.4.3 (line 8) and webpack-cli v3.3.12 (line 11). Webpacker 5 is designed for Webpack 4 and uses internal APIs that changed in version 5. Additionally, Webpack 5 requires webpack-cli v4 or higher. This change will break the build process. Also, as noted in the PR description, the yarn.lock file was not updated, which means the environment will remain inconsistent until manually fixed.

"webpack-cli": "^3.3.12"
},
"version": "0.1.0",
Expand Down
Loading