Handle some race conditions in Docker proxy & network monitoring

Not totally clear if these are the culprit, but there's some untraceable
missing container errors coming from somewhere, and there's certainly
possible race conditions in these cases.

Author: pimterry

src/interceptors/docker/docker-networking.ts

@@ -280,11 +280,13 @@ class DockerNetworkMonitor {
             return undefined;
         }
 
-        const networkContainers = await Promise.all(
+        const networkContainers = (await Promise.all(
             Object.values(networkDetails.Containers ?? {}).map((networkContainer) =>
-                this.docker.getContainer(networkContainer.Name).inspect()
+                this.docker.getContainer(networkContainer.Name)
+                    .inspect()
+                    .catch(() => undefined) // There's a race condition here - skip any now-missing containers
             )
-        );
+        )).filter((container) => !!container) as Docker.ContainerInspectInfo[];
 
         if (!networkContainers.find((container) => this.isInterceptedContainer(container))) {
             // If we're not tracking any containers in this network, we don't need its aliases.
@@ -375,7 +377,11 @@ class DockerNetworkMonitor {
 
                     const linkedContainer = networkContainers.find(c => c.Name === linkedContainerName)
                         // Container should always be in the same network AFAICT, but fallback to lookup just in case:
-                        ?? await this.docker.getContainer(linkedContainerName).inspect();
+                        ?? await this.docker.getContainer(linkedContainerName)
+                            .inspect()
+                            .catch(() => undefined); // There's a race condition here - skip any now missing containers
+
+                    if (!linkedContainer) return [];
 
                     const linkedContainerIp = linkedContainer.NetworkSettings.Networks[networkId]?.IPAddress ||
                         linkedContainer.NetworkSettings.IPAddress;

src/interceptors/docker/docker-proxy.ts

@@ -152,9 +152,9 @@ async function createDockerProxy(proxyPort: number, httpsConfig: { certPath: str
         const startContainerMatch = START_CONTAINER_MATCHER.exec(reqPath);
         if (startContainerMatch) {
             const containerId = startContainerMatch[1];
-            const containerData = await docker.getContainer(containerId).inspect();
+            const containerData = await docker.getContainer(containerId).inspect().catch(() => undefined);
 
-            if (!isInterceptedContainer(containerData, proxyPort)) {
+            if (containerData && !isInterceptedContainer(containerData, proxyPort)) {
                 res.writeHead(400).end(
                     "HTTP Toolkit cannot intercept startup of preexisting non-intercepted containers. " +
                     "The container must be recreated here first - try `docker run <image>` instead."