Skip to content

Commit 374025b

Browse files
committed
Improve k8s deployment setup
We now use the sha explicitly rather than the confusing GH var (I think this is just set to 'prod' anyway) and we actively listen for the deployment to complete.
1 parent f84e71e commit 374025b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,13 @@ jobs:
165165
166166
- name: Deploy to Kubernetes
167167
run: |
168-
sed "s|/website:latest|/website:${{ vars.DOCKER_IMAGE_TAG }}|g" deploy/deployment.yaml | \
168+
sed "s|/website:latest|/website:sha-${GITHUB_SHA::7}|g" deploy/deployment.yaml | \
169169
kubectl apply -f - \
170170
-f deploy/service.yaml \
171171
-f deploy/routes.yaml
172172
173+
kubectl rollout status deployment/httptoolkit-website -n httptoolkit-website
174+
173175
- name: Redeploy container
174176
uses: httptoolkit/deploy-scaleway-serverless-container-action@v1
175177
with:

0 commit comments

Comments
 (0)