Skip to content

Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huan merged 2 commits into from
Nov 10, 2025
Merged

Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6726e82
Initial plan
Copilot Nov 10, 2025
7f13d68
Add GOOGLE_GENAI_USE_VERTEXAI to setup script for both automatic and …
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/setup_workload_identity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ if command -v gh &> /dev/null; then
gh variable set GOOGLE_CLOUD_PROJECT --body "${GOOGLE_CLOUD_PROJECT}" --repo "${GITHUB_REPO}"
gh variable set GOOGLE_CLOUD_LOCATION --body "${GOOGLE_CLOUD_LOCATION}" --repo "${GITHUB_REPO}"
gh variable set SERVICE_ACCOUNT_EMAIL --body "${SERVICE_ACCOUNT_EMAIL}" --repo "${GITHUB_REPO}"
gh variable set GOOGLE_GENAI_USE_VERTEXAI --body "true" --repo "${GITHUB_REPO}"

print_success "GitHub variables have been set automatically!"
else
Expand All @@ -473,6 +474,10 @@ else
echo "☁️ Variable Name: SERVICE_ACCOUNT_EMAIL"
echo " Variable Value: ${SERVICE_ACCOUNT_EMAIL}"
echo ""
echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI"
echo " Variable Value: true"
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parenthetical note mentions using GOOGLE_GENAI_USE_GCA but doesn't provide guidance on which variable to set or if both can be set simultaneously. Consider clarifying that these are mutually exclusive options, or explain that users should choose one based on their needs. For example: "(Set to 'true' to use Vertex AI. Alternatively, use GOOGLE_GENAI_USE_GCA='true' for Code Assist instead)"

Suggested change
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
echo " (Set to 'true' to use Vertex AI. Alternatively, set GOOGLE_GENAI_USE_GCA='true' for Code Assist. These options are mutually exclusive; set only one based on your needs.)"

Copilot uses AI. Check for mistakes.
echo ""
fi

print_success "Setup completed successfully! 🚀"