[3/3] refactor: replace PromotedWidgetView with store-backed WidgetId projection#3
Draft
huang47 wants to merge 1 commit into
Draft
Conversation
…ction The atomic promotion-mechanism swap (3/3). ~15 consumers read the old PromotedWidgetView object model which the new input-slot projection removes; SubgraphNode cannot host both, so store/litegraph/projection/consumers/tests migrate as one unit. See temp/plans/no-promotions-stack.md for the contract ledger. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/3 — stacked on 2/3.
Base:
shihchi/no-promo-2-widget-id· Adds: the atomicPromotedWidgetView→ store-backedWidgetIdprojection swap.The irreducible core. ~15 consumers read the removed
PromotedWidgetViewobject model (isPromotedWidgetView,widget.sourceNodeId/sourceWidgetName,resolvePromotedWidgetSource); the new input-slot projection deletes them andSubgraphNodecannot host both models, so store / litegraph / projection / consumers / tests migrate as one unit.Contract changes to review:
nodeIdnow string; promoted widget name = input-slot name;renderKeyformat; error-arg reshuffle;resolveNodeWidgetdrops its promoted branch; strict widget-id parse.104 files. Stack tip is byte-identical to
drjkl/no-promotionsplus the 1/3 seam test.