CAT-1457 Update cell populations template to use scellop#139
Merged
Conversation
thomcsmits
requested changes
Nov 7, 2025
thomcsmits
left a comment
thomcsmits
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking a look at this @NickAkhmetov !
Most of the functions are renamed in scellop for clarity and removal of HuBMAP specific functions. I was working today on expanding the functions for ScellopData (on this branch and wanted to add these to this template as well. I can add an update next week!
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "scellop.CpWidget(uuids = uuids)" |
Collaborator
There was a problem hiding this comment.
This is obsolete (scellop won't have specific hubmap methods anymore in the python package)
Comment on lines
+100
to
+101
| "df = scellop.cpAnnDataList(anndataLocationList, hubmap_ids, \"predicted_CLID\")\n", | ||
| "scellop.CpWidget(df=df)" |
Collaborator
There was a problem hiding this comment.
these are now renamed for clarity to "load_data_multiple" for a list of multiple sources
NickAkhmetov
changed the title
Collaborator
|
Added a fix in #140 ! Other than that, it's good to go I think! I really like the extensive description you added to the template! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises the scalable cell populations template to use
scellop, the new package name forcellpop.