fixes

Author: jdchawla29

hud/tools/computer/gemini.py

@@ -232,8 +232,10 @@ async def _finalize(
             requested_url: str | None = None,
             output: str | None = None,
         ) -> list[ContentBlock]:
-            if output is not None and not result.error:
+            if output is not None and result.error is None:
                 result.output = output
+            elif result.error == "":
+                result.error = "Tool execution failed with no error output"
             if result.base64_image and self.rescale_images:
                 try:
                     result.base64_image = await self._rescale_screenshot(result.base64_image)

hud/tools/computer/tests/test_computer.py

@@ -36,6 +36,11 @@ async def drag(self, path, pattern=None, hold_keys=None, take_screenshot=True):
         return await super().drag(path, pattern, hold_keys, take_screenshot=False)
 
 
+class EmptyErrorExecutor(BaseExecutor):
+    async def click(self, *args, **kwargs):
+        return ContentResult(error="")
+
+
 @pytest.mark.asyncio
 async def test_hud_computer_screenshot():
     comp = HudComputerTool()
@@ -100,6 +105,17 @@ async def test_gemini_computer_click_reports_model_coordinates():
     )
 
 
+@pytest.mark.asyncio
+async def test_gemini_computer_does_not_mask_empty_error():
+    comp = GeminiComputerTool(executor=EmptyErrorExecutor())
+
+    blocks = await comp(action="click_at", x=214, y=420)
+    text = "\n".join(content.text for content in blocks if isinstance(content, TextContent))
+
+    assert "Clicked at (214, 420)" not in text
+    assert "Tool execution failed with no error output" in text
+
+
 @pytest.mark.asyncio
 async def test_anthropic_computer_zoom():
     """Test zoom action on AnthropicComputerTool.
@@ -246,6 +262,19 @@ async def test_xdo_commands_use_execution_pixels_for_agent_coordinates():
     assert executor.commands[-1] == "mousemove 309 396 click 1"
 
 
+@pytest.mark.asyncio
+async def test_xdo_nonzero_empty_stderr_surfaces_error(monkeypatch):
+    async def fake_run(command: str):
+        return 1, "", ""
+
+    monkeypatch.setattr("hud.tools.executors.xdo.run", fake_run)
+    executor = XDOExecutor()
+
+    result = await executor.execute("mousemove 1 2", take_screenshot=False)
+
+    assert result.error == "Command failed with exit code 1"
+
+
 class TestHudComputerToolExtended:
     """Extended tests for HudComputerTool covering edge cases and platform logic."""
 

hud/tools/executors/xdo.py

@@ -5,11 +5,13 @@
 import logging
 import os
 import shlex
-from pathlib import Path
+from contextlib import suppress
 from tempfile import gettempdir
 from typing import Literal
 from uuid import uuid4
 
+from anyio import Path
+
 from hud.tools.types import ContentResult
 from hud.tools.utils import run
 
@@ -141,9 +143,14 @@ async def execute(self, command: str, take_screenshot: bool = True) -> ContentRe
         # Execute command
         returncode, stdout, stderr = await run(full_command)
 
+        error = None
+        if returncode != 0:
+            error = stderr or f"Command failed with exit code {returncode}"
+
         # Prepare result
         result = ContentResult(
-            output=stdout if stdout else None, error=stderr if stderr or returncode != 0 else None
+            output=stdout if stdout else None,
+            error=error,
         )
 
         # Take screenshot if requested
@@ -167,7 +174,7 @@ async def screenshot(self) -> str | None:
         # Real screenshot using scrot
         if OUTPUT_DIR:
             output_dir = Path(OUTPUT_DIR)
-            output_dir.mkdir(parents=True, exist_ok=True)
+            await output_dir.mkdir(parents=True, exist_ok=True)
             screenshot_path = output_dir / f"screenshot_{uuid4().hex}.png"
         else:
             # Generate a unique path in system temp dir without opening a file
@@ -177,12 +184,13 @@ async def screenshot(self) -> str | None:
 
         returncode, _, _stderr = await run(screenshot_cmd)
 
-        if returncode == 0 and screenshot_path.exists():
+        if returncode == 0 and await screenshot_path.exists():
             try:
-                image_data = screenshot_path.read_bytes()
+                image_data = await screenshot_path.read_bytes()
                 # Remove the file unless user requested persistence via env var
                 if not OUTPUT_DIR:
-                    screenshot_path.unlink(missing_ok=True)
+                    with suppress(FileNotFoundError):
+                        await screenshot_path.unlink()
                 return base64.b64encode(image_data).decode()
             except Exception:
                 return None