Skip to content

Commit 1a37bbd

Browse files
Remove the nonexistent openenv[core] extra from the sophistry example and CLI test fixtures (#1020)
The published extras are daytona, aca, modal and inspect. There is no `core`, so `openenv[core]` made uv and pip warn before installing the base package anyway, and every HF Jobs log carried the warning. The backfill test's `openenv[core]` assertion is untouched on purpose: it exercises name rewriting over historical `openenv-core` releases, which did declare that extra.
1 parent 1b6e9a9 commit 1a37bbd

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

examples/sophistry_bench_sprint_grpo.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
# /// script
44
# requires-python = ">=3.10"
55
# dependencies = [
6-
# "openenv[core]",
6+
# # Plain `openenv`: there is no `core` extra. The published extras are
7+
# # daytona, aca, modal and inspect, and uv only warns before installing
8+
# # the base package anyway, so the old spelling polluted every job log.
9+
# "openenv",
710
# "trl",
811
# "datasets",
912
# "torch",
@@ -15,7 +18,7 @@
1518
1619
Single-step env, so this is a plain prompt -> completion -> reward GRPO setup:
1720
no `environment_factory`/tool-calling needed. Uses `GenericEnvClient` so the
18-
script only depends on `openenv[core]` from PyPI, which also makes it runnable
21+
script only depends on `openenv` from PyPI, which also makes it runnable
1922
as a standalone `uv` script, including via Hugging Face Jobs:
2023
2124
hf jobs uv run examples/sophistry_bench_sprint_grpo.py --flavor a10g-small \
@@ -26,7 +29,7 @@
2629
(`SUPPORTS_CONCURRENT_SESSIONS = False`), and `from_env()` + `.sync()` can
2730
leave behind an orphaned first connection that occupies that single slot (see
2831
https://github.com/huggingface/OpenEnv/pull/854). Needs the `project_path`
29-
git-clone fix from that PR; until it's released, override the `openenv[core]`
32+
git-clone fix from that PR; until it's released, override the `openenv`
3033
dependency above with a git ref of it.
3134
3235
Run locally:

tests/test_cli/test_push.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def _create_test_openenv_env(env_dir: Path, env_name: str = "test_env") -> None:
4040
pyproject_content = f"""[project]
4141
name = "{env_name}"
4242
version = "0.1.0"
43-
dependencies = ["openenv[core]>=0.2.0"]
43+
dependencies = ["openenv>=0.2.0"]
4444
"""
4545
(env_dir / "pyproject.toml").write_text(pyproject_content)
4646

tests/test_cli/test_validate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ def test_validate_command_accepts_dockerfile_managed_openenv_runtime(
251251
'server = "server.app:main"\n'
252252
)
253253
(env_dir / "server" / "Dockerfile").write_text(
254-
'RUN pip install --no-cache-dir --no-deps "openenv[core]>=0.2.2"\n'
254+
'RUN pip install --no-cache-dir --no-deps "openenv>=0.2.2"\n'
255255
)
256256

257257
result = runner.invoke(app, ["validate", str(env_dir), "--json"])

0 commit comments

Comments
 (0)