Upgrade to datasets 4 (for torchcodec + List)#3207
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
severo
approved these changes
Jul 4, 2025
| ) -> Optional[SupportedColumns]: | ||
| if isinstance(dataset_feature, list) or ( | ||
| isinstance(dataset_feature, dict) and dataset_feature.get("_type") in ("LargeList", "Sequence") | ||
| isinstance(dataset_feature, dict) and dataset_feature.get("_type") in ("LargeList", "List", "Sequence") |
Collaborator
There was a problem hiding this comment.
why do we keep testing "Sequence" here?
Member
Author
There was a problem hiding this comment.
because of existing datasets: in the dataset-viewer cache they are Sequence
| for feature_name, feature in features.items(): | ||
| if isinstance(feature, list) or ( | ||
| isinstance(feature, dict) and feature.get("_type") in ("LargeList", "Sequence") | ||
| isinstance(feature, dict) and feature.get("_type") in ("LargeList", "List", "Sequence") |
Collaborator
There was a problem hiding this comment.
why do we keep testing "Sequence" here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @severo for viz :)
It does introduce the List(...) type (instead of Sequence (...)and [...] ), and it translates to a new type of Feature in the OpenAPI spec