fix(e2e): add ResponseNotFound retry to statistics test#3277
Open
The-Obstacle-Is-The-Way wants to merge 1 commit intohuggingface:mainfrom
Open
fix(e2e): add ResponseNotFound retry to statistics test#3277The-Obstacle-Is-The-Way wants to merge 1 commit intohuggingface:mainfrom
The-Obstacle-Is-The-Way wants to merge 1 commit intohuggingface:mainfrom
Conversation
The-Obstacle-Is-The-Way
force-pushed
the
fix/e2e-flaky-statistics-test
branch
2 times, most recently
from
18efa9e to
c141330
Compare
The test_statistics_endpoint was flaky because it failed immediately on ResponseNotFound (404) instead of retrying. This happens when the split-descriptive-statistics worker job hasn't completed yet. This follows the established pattern used in test_55_first_rows.py, test_52_search.py, test_53_filter.py, and test_54_rows.py which all use should_retry_x_error_codes=["ResponseNotFound"] for the same reason.
The-Obstacle-Is-The-Way
force-pushed
the
fix/e2e-flaky-statistics-test
branch
from
c141330 to
c8a5d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky
test_statistics_endpointby adding retry logic forResponseNotFound(404) errors.The test was failing intermittently because it didn't wait for the
split-descriptive-statisticsworker job to complete before asserting.Fix
Added
should_retry_x_error_codes=["ResponseNotFound"]- the same pattern already used in:test_52_search.pytest_54_rows.pytest_55_first_rows.pyChange
+2 lines, follows existing codebase pattern.