Skip to content

Fix: Add validation to prevent duplicate kwargs in load_dataset_builder #8106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lohith360 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix: Add validation to prevent duplicate kwargs in load_dataset_builder #8106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,13 @@ def load_dataset_builder(
'text': Value('string')}
```
"""
args = {"name", "data_dir", "data_files", "cache_dir", "features", "download_config", "download_mode", "revision", "token", "storage_options"}
conf = set(config_kwargs.keys())
dupes = args & conf

if dupes:
err = f"Duplicate keys found: {dupes}"
raise ValueError(err)
download_mode = DownloadMode(download_mode or DownloadMode.REUSE_DATASET_IF_EXISTS)
if token is not None:
download_config = download_config.copy() if download_config else DownloadConfig()
Expand Down