Skip to content

fix: report the correct variable type in fingerprint_transform ignore_kwargs validation error #8272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kropiunig wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: report the correct variable type in fingerprint_transform ignore_kwargs validation error #8272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasets/fingerprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def fingerprint_transform(
raise ValueError(f"use_kwargs is supposed to be a list, not {type(use_kwargs)}")

if ignore_kwargs is not None and not isinstance(ignore_kwargs, list):
raise ValueError(f"ignore_kwargs is supposed to be a list, not {type(use_kwargs)}")
raise ValueError(f"ignore_kwargs is supposed to be a list, not {type(ignore_kwargs)}")

if inplace and fingerprint_names:
raise ValueError("fingerprint_names are only used when inplace is False")
Expand Down