Skip to content

Fix fixed size binary #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-PLACET wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix fixed size binary #8281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d81702b
Support fixed_size_binary and list pyarrow types in features dtype co…
Alex-PLACET Jun 10, 2026
ea76ca4
wip
Alex-PLACET Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/datasets/features/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ def _arrow_to_datasets_dtype(arrow_type: pa.DataType) -> str:
return "large_string"
elif pyarrow.types.is_string_view(arrow_type):
return "string_view"
elif pyarrow.types.is_fixed_size_binary(arrow_type):
return f"fixed_size_binary[{arrow_type.byte_width}]"
elif pyarrow.types.is_dictionary(arrow_type):
return _arrow_to_datasets_dtype(arrow_type.value_type)
else:
Expand Down Expand Up @@ -266,6 +268,11 @@ def _dtype_error_msg(dtype, pa_dtype, examples=None, urls=None):
],
)
)

fixed_size_binary_matches = re.search(r"^fixed_size_binary\[(\d+)\]$", datasets_dtype)
if fixed_size_binary_matches:
byte_width = fixed_size_binary_matches.group(1)
return pa.binary(int(byte_width))

raise ValueError(
f"Neither {datasets_dtype} nor {datasets_dtype + '_'} seems to be a pyarrow data type. "
Expand Down
1 change: 1 addition & 0 deletions tests/features/test_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def test_string_to_arrow_bijection_for_primitive_types(self):
pa.int32(),
pa.float64(),
pa.array([datetime.time(1, 1, 1)]).type, # arrow type: DataType(time64[us])
pa.binary(16),
]
for dt in supported_pyarrow_datatypes:
self.assertEqual(dt, string_to_arrow(_arrow_to_datasets_dtype(dt)))
Expand Down